tests/socket_zep: fix automatic test#17432
Conversation
Murdock does not support IPv6, so use IPv4 for the automated test.
kfessel
left a comment
There was a problem hiding this comment.
Changes seem sound,
Test in CI was run.
https://ci.riot-os.org/RIOT-OS/RIOT/17432/79891e93181dca6fc2f2086dce0e49fec2566499/output/compile/tests/socket_zep/native:gnu.txt
Just a small question
| _main_pid = thread_getpid(); | ||
|
|
||
| test_init(); | ||
| test_send__iolist_NULL(); |
There was a problem hiding this comment.
Why did you remove this part of the test ?
There was a problem hiding this comment.
With the radio HAL sending a NULL buffer will no longer result in any data being transmitted. Previously this would send a header-only packet (and this test would verify that).
There was a problem hiding this comment.
maybe:
Elements of this list may have iolist_t::iol_size == 0 and (in this case only) iolist_t::iol_data == 0
should be tested instead
There was a problem hiding this comment.
I think this makes no sense. We are on layer 2 here, so for a real device this would mean no data on the bus / air.
Only with the (old) ZEP implementation this would write the ZEP header (that wraps the IEEE 802.15.4 frame).
Mind you that we are using the sub-mac now which does make assumptions about the contents being transmitted (namely them being a IEEE 802.15.4 frame) - we'd now need to add checks there, e.g in sys/net/link_layer/ieee802154/submac.c:414 where it checks if the ACK_REQ bit is set - for a case that will never happen in reality.
kfessel
left a comment
There was a problem hiding this comment.
changes are sound, test ran by murdock, removal of unneeded test explained -> question resolved
Contribution description
The automatic test for socket ZEP was broken because it did not run on Murdock. This PR attempts to fix this:
nativeinstance always uses the same addressTesting procedure
should now work again.
Issues/PRs references
fixes #16946 (comment)