drivers/cc110x: use pseudo-modules for band selection#16865
Merged
Conversation
benpicco
added
the
Type: enhancement
github-actions
Bot
added
Area: boards
maribu
approved these changes
Sep 16, 2021
maribu
left a comment
maribu
left a comment
Member
There was a problem hiding this comment.
Looks good to me. In a fellow up one could consider dropping the frequency config only needed for non-868 MHz, I'm not really happy with that design decision anymore.
I have no hardware to test at hands, but I trust your testing.
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
drivers/cc110x-submodules
branch
from
edc2dd7 to
25a5df2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
CC110x modules on ebay are commonly using the 433 MHz band.
Add a pseudo-module for band selection and default to that band, manually select band for 868 MHz boards.
Testing procedure
The code should not change compared to
master.Boards from this branch (e.g
msba2) should still be able to communicate with boards on the master branch.Issues/PRs references
#16232 (comment)