Skip to content

ci/build_system_check: improve check for features only provided in Makefile.features #14511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjmolinas merged 1 commit into from
Jul 20, 2020
Merged

ci/build_system_check: improve check for features only provided in Makefile.features #14511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/tools/buildsystem_sanity_check/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ check_providing_features_only_makefile_features() {
local patterns=()
local pathspec=()

patterns+=(-e 'FEATURES_PROVIDED *+= *')
patterns+=(-e '^[ ]*FEATURES_PROVIDED *+= *')

pathspec+=("boards/*Makefile*" "cpu/*Makefile*")
pathspec+=("*Makefile\.*")

pathspec+=(":!*Makefile.features")

git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \
| error_with_message 'Features in cpu and boards should only be provided in Makefile.features files'
| error_with_message 'Features should only be provided in Makefile.features files'
}

# Some variables do not need to be exported and even cause issues when being
Expand Down