sys/pthread: check return value of malloc()#12511
Merged
Merged
Conversation
benpicco
added
Type: bug
benpicco
force-pushed
the
pthread-malloc_check
branch
from
9bcc560 to
693889b
Compare
benpicco
added
the
CI: ready for build
maribu
reviewed
Oct 19, 2019
maribu
approved these changes
Oct 20, 2019
maribu
left a comment
maribu
left a comment
Member
There was a problem hiding this comment.
ACK. I'm 100% sure that the added error handleding is not breaking anything.
To prevent a NULL pointer dereference on a memory constrained system, check if malloc() was actually successful.
benpicco
force-pushed
the
pthread-malloc_check
branch
from
496d286 to
764a9e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
To prevent a NULL pointer dereference on a memory constrained system, check if
malloc()was actually successful before carrying on.Testing procedure
Flash one of the
tests/pthread*on a memory constrained device.Without this patch you will observe a hard fault.
Issues/PRs references
discovered on #12433