boards/nucleo32: fix arduino pinmap for nucleo-l432kc#12381
Merged
aabadie merged 1 commit intoOct 8, 2019
Conversation
aabadie
added
Type: bug
benpicco
approved these changes
Oct 7, 2019
benpicco
left a comment
benpicco
left a comment
Contributor
There was a problem hiding this comment.
The change is small enough, the board was probably never extensively used with the Arduino compatibility layer before.
I trust you testing / data sheet reading.
Contributor
Author
|
I could test this PR with #12388 and it fixes the mentioned issue on nucleo-l432kc. The CI is all green, so let's merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is fixing the Arduino pinmap of D7/D8 for nucleo-l432kc, as reported in #12138.
I checked the user manual of nucleo32 boards and only nucleo-l432kc needs this change. The other nucleo32 impacted board is nucleo-l412kb but is not supported yet (but is provided by #12144)
Testing procedure
Write an application that uses ARDUINO_PIN_7 and ARDUINO_PIN_8, build it on nucleo-l432kc and verify it is working compared to master (I'll write something and give a link here if needed).
Issues/PRs references
fixes #12138