drivers/include/periph/eeprom: Changed uint8_t* to void* in API#11990
Merged
benpicco merged 1 commit intoAug 11, 2019
Merged
Conversation
Member
|
|
Member
|
As this is an API change, 2 ACKs are formally required. (This change will not break any caller, as @benpicco: Mind to have a look? |
benpicco
approved these changes
Aug 11, 2019
benpicco
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Interestingly both implementations already cast the argument to uint8_t* internally, so there really is no semantic change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This tiny PR changes the EEPROM API for eeprom_read and eeprom_write
to expect void* data instead of uint8_t* data. This suggests a more general interface.
Testing procedure
I executed tests/eepreg and tests/periph_eeprom on arduino-mega2560.
Issues/PRs references
This PR has emerged from PR #11929 .