pkg/nimble: bump version to 997dad8#11949
Merged
Merged
Conversation
haukepetersen
added
Type: enhancement
miri64
reviewed
Aug 1, 2019
miri64
left a comment
miri64
left a comment
Member
There was a problem hiding this comment.
ACK example and test still work as expected. I'd like to point out though, that if I
inctest
[…]
flood 5000 10
the client node hangs. Is this a known issue?
haukepetersen
force-pushed
the
opt_nimble_ver997dad8
branch
from
7c8fc9d to
7e9c7ee
Compare
Contributor
Author
|
miscalculated the needed msys blocksize by 6 bytes. Now everything does run fine here. |
miri64
added
Reviewed: 1-fundamentals
miri64
approved these changes
Aug 1, 2019
miri64
left a comment
miri64
left a comment
Member
There was a problem hiding this comment.
ACK nimble_l2cap no longer hangs under the conditions previously described and the nimble_gatt example also still works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Straight forward version dump for the NimBLE pkg. There were several fixes merged into NimBLEs master that are important for RIOT, e.g. some configuration value adjustment to cater for nrf51 targets.
Testing procedure
Verify that the
examples/nimble_gattandtests/nimble_l2capapplications are still working as expected.Issues/PRs references
#11463 is waiting on this