boards/nrf51-based: split shared timer/rtt config#11625
Merged
Conversation
haukepetersen
added
Type: cleanup
aabadie
reviewed
Jun 4, 2019
aabadie
left a comment
aabadie
left a comment
Contributor
There was a problem hiding this comment.
Looks good in general. I can test this on nrf51dk and microbit. I don't have access to the other boards.
Contributor
Author
|
IMHO a thorough review combined with the build-test should do for the others, as all of them are equal to either of those two boards. |
aabadie
requested changes
Jun 4, 2019
aabadie
left a comment
aabadie
left a comment
Contributor
There was a problem hiding this comment.
The CI is complaining because of invalid header guards. You can squash directly.
Otherwise, I tested tests/periph_timer and a couple of xtimer test applications on microbit and nrf51dk with success.
| * @author Hauke Petersen <hauke.petersen@fu-berlin.de> | ||
| */ | ||
|
|
||
| #ifndef PERIPH_CONF_COMMON_H |
Contributor
There was a problem hiding this comment.
As reported by the CI, the guard must be updated as well.
| * @author Hauke Petersen <hauke.petersen@fu-berlin.de> | ||
| */ | ||
|
|
||
| #ifndef PERIPH_CONF_COMMON_H |
haukepetersen
force-pushed
the
opt_nrf51_timerrttcfg
branch
from
a15998a to
44625ec
Compare
Contributor
Author
|
fixed the header guards, and squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR streamlines the shared RTT and timer configuration for
nrf51-based boards:microbitandcalliopeuseTIMER_DEV(2)for their LED-matrix driverTesting procedure
Run
tests/periph_timerfor any of the effected boardsIssues/PRs references
enables simpler adaption of #11463