examples/nimble*: add more nrf52 based boards in whitelist#11372
Closed
aabadie wants to merge 1 commit into
Closed
examples/nimble*: add more nrf52 based boards in whitelist#11372aabadie wants to merge 1 commit into
aabadie wants to merge 1 commit into
Conversation
aabadie
added
Impact: minor
aabadie
force-pushed
the
pr/examples/nimble_boards_whitelist
branch
from
84cebfe to
e58e361
Compare
Contributor
|
@aabadie could we find a more generic way?, if #10563 gets merged that would mean +3 boards to manage, +4 if we split boron LTE and 2G/3G. Could we use some kind of feature for this? For example using one of these: I think using |
Contributor
Contributor
Author
This is exactly what I had in mind :) |
Contributor
Author
|
@fjmolinas, I opened #11673 to address your proposal. It's indeed much cleaner :) |
Contributor
Author
|
Closing in favor of #11673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds all nrf52 based boards supported in RIOT to the board whitelist of nimble applications.
I know this solution is not the most maintainable but since there are not so many nrf52 based boards in RIOT, it should be fine for now.
Testing procedure
examples/nimble_*should work on the boards (they do on nrf52xxx-mdk boards)Issues/PRs references
None