Skip to content

gnrc_netif: fix DEBUG output on error#11285

Merged
danpetry merged 1 commit into
RIOT-OS:masterfrom
miri64:gnrc_netif/fix/debug-send-error
Mar 26, 2019
Merged

gnrc_netif: fix DEBUG output on error#11285
danpetry merged 1 commit into
RIOT-OS:masterfrom
miri64:gnrc_netif/fix/debug-send-error

Conversation

@miri64

@miri64 miri64 commented Mar 26, 2019

Copy link
Copy Markdown
Member

Contribution description

res is an integer that is always negative in the given case, so using %u here might be a little bit confusing.

Testing procedure

If you really don't trust my change I guess you have to figure out how to trigger an error without #11264 ;-).

Issues/PRs references

None, but noticed it while working on #11263.

`res` is an integer that is always negative in the given case, so using
`%u` here might be a little bit confusing.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 26, 2019
@miri64 miri64 requested review from danpetry and kaspar030 March 26, 2019 17:27

@danpetry danpetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. ACK

@miri64

miri64 commented Mar 26, 2019

Copy link
Copy Markdown
Member Author

Thanks for the quick review! :-)

@danpetry danpetry merged commit 0d81f7c into RIOT-OS:master Mar 26, 2019
@miri64 miri64 deleted the gnrc_netif/fix/debug-send-error branch March 26, 2019 18:35
@danpetry danpetry added this to the Release 2019.04 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants