Skip to content

Align verbose SSH env handling across SSH connection paths#108

Merged
so5 merged 4 commits into
masterfrom
copilot/fix-failing-github-actions-job-test
Jun 5, 2026
Merged

Align verbose SSH env handling across SSH connection paths#108
so5 merged 4 commits into
masterfrom
copilot/fix-failing-github-actions-job-test

Conversation

Copilot AI commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

The failing test job traced back to inconsistent WHEEL_VERBOSE_SSH handling in the server SSH codepaths. sshManager normalized false-like values, but tryToConnect still treated any non-empty string as enabled.

  • Root cause

    • server/app/handlers/tryToConnect.js used a raw truthiness check:
      • "false" and "0" still enabled sshOpt: ["-vvv"]
    • server/app/core/sshManager.js already had the intended normalization logic
  • What changed

    • Reused sshManager's isVerboseSshEnabled() helper from tryToConnect
    • Exported the helper from server/app/core/sshManager.js
    • Added focused unit coverage for tryToConnect to lock in behavior for:
      • truthy values
      • false-like values
  • Behavioral effect

    • Both SSH entry points now interpret WHEEL_VERBOSE_SSH consistently
    • False-like values no longer inject verbose SSH flags during connection checks
  • Example

    // before
    if (process.env.WHEEL_VERBOSE_SSH) {
      hostInfo.sshOpt = ["-vvv"];
    }
    
    // after
    if (isVerboseSshEnabled()) {
      hostInfo.sshOpt = ["-vvv"];
    }

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'test' Align verbose SSH env handling across SSH connection paths Jun 5, 2026
Copilot finished work on behalf of so5 June 5, 2026 12:52
Copilot AI requested a review from so5 June 5, 2026 12:52
@so5 so5 marked this pull request as ready for review June 5, 2026 13:10
@so5 so5 merged commit 7dbaa77 into master Jun 5, 2026
so5 added a commit that referenced this pull request Jun 5, 2026
@so5 so5 deleted the copilot/fix-failing-github-actions-job-test branch June 7, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants