Repository navigation
Implement dynamic APCA contrast calculation for primary color pair - #26
Open
google-labs-jules[bot] wants to merge 1 commit into
Open
google-labs-jules[bot] wants to merge 1 commit into
google-labs-jules[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The design simulator previously logged a static compliance success message for APCA contrast checks rather than executing actual calculation logic. While a prior fix attempted to replace this static log, it introduced a bug by using the document's global
minLightnessandmaxLightnessvalues. This meant that changing the primary color's lightness didn't accurately reflect in the contrast report unless they happened to be the absolute limits of the entire page.To ensure high-integrity accessibility audits, we need to evaluate the actual primary foreground and background color pair dynamically.
What
We have updated the design simulator to target and parse specific design system tokens, providing accurate perceptual contrast metrics without impacting other systems.
design-simulator.jsto scancssTextandhtmlContentfor--color-primaryand--color-backgroundvariables defined with OKLCH values.Constraints Addressed