Repository navigation
Implement dynamic APCA contrast calculation in design simulator - #25
Merged
REX-codebase merged 1 commit intoJul 18, 2026
Conversation
…ed logging string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The design simulator previously logged a hardcoded success message (
APCA Contrast Verification: Perceptual Lightness Compliance Checked) during accessibility audits. Because this static message bypassed the actual calculation logic, it produced false-positive compliance reports that could easily mask illegible color choices.To improve the integrity of our design system audits, this PR replaces the hardcoded string with a dynamic APCA contrast calculation. Designers and developers will now receive accurate, real-time feedback on color legibility.
Key Decisions & Rationale
calculatePerceptualContrasthelper rather than introducing external packages, keeping the codebase lightweight and maintainable.What Changed
"APCA Contrast Verification: Perceptual Lightness Compliance Checked."log insideskills/utils/design-simulator.js.runTasteAuditsto return thecolorMetricscontainingminLightnessandmaxLightnessderived from OKLCH rules.calculatePerceptualContrasthelper.- APCA Contrast Verification: Calculated Lc <value> (Primary Pair).