Gate tilemap editor behind admin permission check#1513
Closed
JakubIwicki wants to merge 1 commit into
Closed
Conversation
Adds AdminFunctionsForAll setting to PermissionSettings and restricts the tilemap editor toggle to administrators only unless the admin-functions-for-all override is enabled. Closes RE-SS3D#1280
Collaborator
|
PRs by AI agents are not allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1280
The tilemap editor was accessible to all players regardless of role. This gates it behind the admin permission check so only administrators can open it.
Changes
Assets/Scripts/SS3D/Permissions/PermissionSettings.cs— addedAdminFunctionsForAllbool setting that allows hosts to opt-in to letting all players use admin functionsAssets/Scripts/SS3D/Systems/Tile/TileMapCreator/TileMapMenuSubSystem.cs— addedCanAccessTilemapEditor()permission check preventing non-admin players from opening the tilemap editorVerification
AdminFunctionsForAllis falseAdminFunctionsForAllis true, all users can access the tilemap editor