Skip to content

Show property defaults when printing a class#634

Merged
hadley merged 9 commits into
mainfrom
show-defaults
Jun 1, 2026
Merged

Show property defaults when printing a class#634
hadley merged 9 commits into
mainfrom
show-defaults

Conversation

@hadley
Copy link
Copy Markdown
Member

@hadley hadley commented May 25, 2026

Fixes #439

Comment thread tests/testthat/_snaps/class.md Outdated
Comment thread tests/testthat/_snaps/class.md Outdated
Comment thread tests/testthat/_snaps/class.md
@hadley hadley requested a review from t-kalinowski May 26, 2026 13:35
@hadley
Copy link
Copy Markdown
Member Author

hadley commented May 26, 2026

@t-kalinowski I don't think this is done, but it's at a point where it would be useful for you to react to. In particular, the challenge is default values for thinks like class_factor and class_Date, and generally how far we want to try to go to figure them out.

Copy link
Copy Markdown
Member

@t-kalinowski t-kalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice addition!

Comment thread tests/testthat/_snaps/property.md Outdated
@hadley hadley requested a review from t-kalinowski May 29, 2026 19:10
@hadley hadley merged commit e79fa19 into main Jun 1, 2026
13 checks passed
@hadley hadley deleted the show-defaults branch June 1, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update S7_class print() method to show property default values

2 participants