Skip to content

Fixed the process when workflow_action_history is not retrieved(#57050) #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivis-miyachi merged 1 commit into from
Dec 27, 2025
Merged

Fixed the process when workflow_action_history is not retrieved(#57050) #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/weko-workflow/weko_workflow/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2503,7 +2503,7 @@ def get_activity_steps(self, activity_id):
his = WorkActivityHistory()
histories = his.get_activity_history_list(activity_id)
if not histories:
abort(404)
return []
history_dict = {}
activity = WorkActivity()
activity_detail = activity.\
Expand Down
7 changes: 6 additions & 1 deletion modules/weko-workflow/weko_workflow/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,9 @@ def render_guest_workflow(file_name=""):
)

form = FlaskForm(request.form)
if not guest_activity.get("steps",[]):
current_app.logger.error("can not get workflow_action_history:{}".format(activity_id))
abort(404)

return render_template(
'weko_workflow/activity_detail.html',
Expand Down Expand Up @@ -880,7 +883,9 @@ def display_activity(activity_id="0", community_id=None):
current_app.logger.error("display_activity: can not get activity display info")
return render_template("weko_theme/error.html",
error="can not get data required for rendering")

if not steps:
current_app.logger.error("can not get workflow_action_history:{}".format(activity_id))
abort(404)
# display_activity of Identifier grant
identifier_setting = None
if action_endpoint == 'identifier_grant' and item:
Expand Down
Loading