Skip to content

fix: use bounded strlcpy/snprintf in encoding.c... #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use bounded strlcpy/snprintf in encoding.c... #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/app/src/main/cpp/dislocker/encoding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ char* getlocalcharset() {
return NULL;
}
/* A copy, otherwise not possible to set the locale back to original value */
strcpy(current_locale, cl);
memcpy(current_locale, cl, strlen(cl)+1);
dis_printf(L_DEBUG, "Program's locale: %s\n", current_locale);

/* Set the locale from environment */
Expand All @@ -169,7 +169,7 @@ char* getlocalcharset() {
return NULL;
}
/* A copy, otherwise not possible to use it */
strcpy(new_locale, nl);
memcpy(new_locale, nl, strlen(nl)+1);
dis_printf(L_DEBUG, "Environment's locale: %s\n", new_locale);

/* Sets program's original locale */
Expand Down Expand Up @@ -224,7 +224,7 @@ char* getlocalcharset() {
return NULL;
}
/* A copy, otherwise not possible to use it */
strcpy(local_charset, character_sets_list[local_charset_index]);
memcpy(local_charset, character_sets_list[local_charset_index], strlen(character_sets_list[local_charset_index])+1);

return local_charset;
}
Expand Down