Conversation
Backend: - app/settings.py: pydantic-settings (OSM2NS3_* env prefix, derived data/static dirs) - app/store.py: SQLite job store (WAL, retention pruning, startup recovery of interrupted jobs) replacing the in-memory dict - app/worker.py: PipelineRunner with semaphore concurrency cap; job cancellation that SIGKILLs the process group before task.cancel() (wait_for won't reap children on cancel); cancel-vs-completion race fixed by re-checking the store before marking done - main.py: create_app factory; streamed 1 MiB uploads with size cap; /live + /ready probes; API-key auth off by default (X-API-Key, env-enabled on /jobs/*); CORS fixed from wildcard; SPA StaticFiles mount with deep-link fallback Tests + CI: - 118 tests (90% coverage): models, command builders, store, full API with mocked SUMO, cancellation machinery - CI rewritten: backend job (pytest --cov ≥80% + uvicorn /health smoke) and frontend job (npm ci + tsc/vite build) Frontend: - API-key input persisted to localStorage and sent as X-API-Key - Schema drift fix: configSchema.ts deleted; form generated from live GET /schema (caught real drift: old code shipped lowercase sotl_phase, wire value SOTL_PHASE) - Job cancel button, blob download (no key-in-URL), cancelled status styling, /health -> /ready switch Ops: - Multi-stage Dockerfile (node build -> ubuntu22.04+SUMO+sumo-tools, non-root, /data volume), .dockerignore, docker-compose.yml - black/isort/ruff config in pyproject.toml + one-time reformat; Lint.yml pinned to the same profile Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend:
Tests + CI:
Frontend:
Ops: