Repository navigation
Keep client PII off public pay, verify, proof, and log surfaces (#559) - #581
Draft
s6pa1rta3n-lab wants to merge 2 commits into
Draft
s6pa1rta3n-lab wants to merge 2 commits into
s6pa1rta3n-lab wants to merge 2 commits into
Conversation
Closes Quittance-Labs#559. PUBLIC_INVOICE_FIELDS is the single allowlist for anonymous pay, payment-info, and verify. SELLER_ONLY_INVOICE_FIELDS names the identity keys that must stay off those responses, proof HTML, mailto bodies, payment-event payloads, and structured logs. Seller workspace reads gated by the invoice Freighter wallet still return client contact. Pay-page types drop the index signature and seller-only fields so a leaked key fails the frontend typecheck. Named whitelist tests fail if a public key is removed or a seller-only key is dropped from the denylist.
Collaborator
|
This can't be merged yet:
Also note #561 targets the same issue (#559). Please rebase, get |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #559.
Summary of Changes
PUBLIC_INVOICE_FIELDSallowlist andSELLER_ONLY_INVOICE_FIELDSdenylist inshared/invoice.ts.GET /invoices/:id,GET /invoices/by-id/:id,GET /invoices/public/:id,POST /invoices/:id/verify,GET /invoices/:id/payment-info).PaymentReceipt.tsxto dynamically evaluate proof email capability so public payers receive an accessible explanatory hint while seller workspace retains proof emailing.created_at) to prevent settlement timestamp unavailability errors.Issue #559 Stipulations Checklist
PUBLIC_INVOICE_FIELDS) on public pay, payment-info, and verify endpointsSELLER_ONLY_INVOICE_FIELDS) from public responses, proof exports, and log eventsPayout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC