Conversation
🤖 Augment PR SummarySummary: This PR adds an opt-in Quip “dev signer” injection flow and a UI path to import Quip accounts by mnemonic/seed. Changes:
Technical Notes: Signer injection is explicitly opt-in (env/query/storage) and uses dynamic imports + WASM initialization before enabling mnemonic import into the injected keyring path. 🤖 Was this summary useful? React with 👍 or 👎 |
| return; | ||
| } | ||
|
|
||
| isInjected = true; |
There was a problem hiding this comment.
packages/apps/src/initQuipSigner.ts:84 — isInjected is set to true before the async dynamic imports/wasm init. If any of those steps throw, the session will be permanently marked as injected and later calls to initQuipSigner() won’t retry even though nothing was actually injected.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| onClose(); | ||
| }) | ||
| .catch((error: Error): void => { | ||
| onStatusChange({ action: 'create', message: error.message, status: 'error' }); | ||
| }) | ||
| .finally(() => setIsBusy(false)); |
There was a problem hiding this comment.
packages/page-accounts/src/modals/QuipMnemonic.tsx:54-59 — On success you call onClose() (likely unmounting the modal) and then .finally(() => setIsBusy(false)) still runs, which can update state after unmount. This can lead to noisy warnings or flaky behavior around closing the modal immediately after import.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
Beware of relative paths! this is not to be merged in it's current state. |
No description provided.