refactor: remove dead contract artifacts#1388
Merged
Baskarayelu merged 1 commit intoJun 20, 2026
Merged
Conversation
Contributor
|
good cleanup - removing the dead contract artifacts trims the crate. merging 🧹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quicklendx-contracts/src/lib.rs.bak, the stale backup copy of the contract entrypoint.quicklendx-contracts/src/events_escrow_stub.rs, which has no remaining module/include/path references.scratch_events.rsandbackup_v1.rsin place because the reference check shows they are still wired through#[cfg(all(test, feature = "legacy-tests"))] mod scratch_events;and the V1 backup compatibility path/tests.Closes #1341
Reference check
rg -n "events_escrow_stub|lib\.rs\.bak|scratch_events|backup_v1" quicklendx-contracts/src quicklendx-contracts/Cargo.toml .github -g "!quicklendx-contracts/cargo_test*.log"events_escrow_stuborlib.rs.bakafter removal.scratch_eventsandbackup_v1, so those files are intentionally retained per the issue guidance to leave referenced files in place.Validation
git diff --checkExisting validation blockers
cargo fmt --all -- --checkreports broad pre-existing formatting drift across the contracts crate; I did not apply formatting to avoid unrelated churn.cargo buildreaches the crate and currently fails on a pre-existingsrc/health.rserror:crate::invoice::InvoiceStorageis a private import andget_total_invoice_countis not found.cargo test --no-runis additionally blocked locally by the Windows GNU toolchain missingdlltool.exewhile compilinggetrandomtest dependencies.cargo clippy --all-targets --all-featurescould not run because the local E: toolchain does not have the clippy component installed.