Redis connection pull - #6
Merged
Merged
Conversation
Move connections_panel.dart, new_connection_dialog.dart, new_folder_dialog.dart, and driver_manager_dialog.dart from features/main_screen/ to features/connections/ for better project organization. Each connector type now has its own dedicated folder under lib/features/.
Move mongodb_connection_form.dart and mongo_databases_view.dart from features/main_screen/ to features/mongodb/. Keeps all MongoDB-specific UI (connection form, databases list, server status view) in a dedicated directory.
Move redis_connection_form.dart and redis_view.dart from features/main_screen/ to features/redis/. All Redis-specific UI (connection form, server info dashboard) is now grouped in its own directory.
Update import paths in main_screen.dart and workspace_panel.dart to reference the new feature directory locations: - connections_panel, new_connection_dialog, driver_manager_dialog -> features/connections/ - mongodb_connection_form, mongo_databases_view -> features/mongodb/ - redis_connection_form, redis_view -> features/redis/
- redis_info_test.dart: tests for parseRedisInfo() and helper functions (sectionValue, sectionInt, sectionDouble) - redis_connection_test.dart: tests for RedisConnection initial state, disconnect safety, and error handling - redis_service_test.dart: tests for RedisService.createConnection(), getConnection(), disconnect(), and validation
- mongo_service_test.dart: tests for MongoService.createConnection(), getConnection(), validation, and connection replacement - mongo_connection_data_test.dart: tests for MongoConnectionData validation logic (isValid) and default values
- mongodb_connection_test.dart: comprehensive tests for MongoConnection.buildConnectionUri() and initial state - connection_row_test.dart: tests for ConnectionRow serialization (toMap/fromMap), round-trip, and edge cases
- Run tests on push/PR to main, dev, and connector branches - Run flutter analyze for code quality checks - Uses Flutter 3.38.5 stable channel - Both jobs run in parallel on Ubuntu latest
- driver_urls.dart: add library directive to fix dangling doc comment - folders_storage.dart: add curly braces in for loop - app_theme.dart: use const with ThemeData.dark and Typography.geist()
- connections_panel.dart: const Text and Padding widgets - driver_manager_dialog.dart: const constructors, remove unused _refreshStatus - new_connection_dialog.dart: const Dialog and Text widgets - new_folder_dialog.dart: const Dialog and Text widgets
- main_screen.dart: const SizedBox, Text, Icon widgets; sort child properties last - query_editor_tab.dart: const Padding and Card widgets - results_tab.dart: fix const Center with non-const child
- mongo_databases_view.dart: remove unused BorderSide, MainAxisAlignment, Divider imports; add const Text widgets - mongodb_connection_form.dart: add const Text, Divider, SizedBox, CircularProgressIndicator widgets
- redis_connection_form.dart: const Text, Divider widgets - redis_view.dart: const Text, SizedBox, CircularProgressIndicator widgets
- mongo_service_test.dart: const ConnectionRow instances - redis_service_test.dart: const ConnectionRow instances - connection_row_test.dart: const ConnectionRow instances
ZhuchkaTriplesix
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.