Skip to content

fix(extensions): edit-connection UI parity (#518) - #519

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/518-extension-edit-ui-parity
Jul 28, 2026
Merged

fix(extensions): edit-connection UI parity (#518)#519
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/518-extension-edit-ui-parity

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • SDUI edit mode: blank required passwords validate; hint Leave blank to keep existing (keepExistingSecrets)
  • Extension Test Connection merges stored secrets like Save
  • Extension sidebar: remove inline × — Remove only via context menu (matches built-ins)
  • Extract connection_edit_secrets.dart so extension form can merge without a circular import

Closes #518

Test plan

  • Edit extension connection with required password → leave blank → Save keeps secret
  • Same edit → Test Connection with blank password uses stored secret
  • Extension tile has no trailing ×; Remove only from context menu
  • Create extension connection still requires password when schema marks it required
  • flutter test test/core/sdui/sdui_builders_test.dart test/features/connections/connection_edit_helpers_test.dart test/core/storage/local_db_secrets_test.dart

Allow blank required SDUI passwords when editing, merge secrets on Test,
and drop the duplicate inline Remove control on extension tiles.
@github-actions github-actions Bot added bug Something isn't working marketplace Extensions marketplace, ExtensionManifest ui User interface components and widgets connections Database connections, URI parsing, pools labels Jul 28, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit bd84e67 into dev Jul 28, 2026
4 checks passed
@ZhuchkaTriplesix ZhuchkaTriplesix self-assigned this Jul 29, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/518-extension-edit-ui-parity branch July 30, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working connections Database connections, URI parsing, pools marketplace Extensions marketplace, ExtensionManifest ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant