Skip to content

ui(icons): drop unused sduiNode size token (#497) #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 28, 2026
Merged

ui(icons): drop unused sduiNode size token (#497) #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/core/sdui/sdui_tree_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ class SduiTreeBuilderState extends material.State<SduiTreeBuilder> {
final isLoading = _loading.contains(node.id);
final nodeKind = _resolveNodeKind(node);
final isBrowsable = nodeKind == 'table' || nodeKind == 'view';
// Same hierarchy as native trees (#476 / #497) — no separate sduiNode size.
final iconSize =
canExpand ? QueryaIconSizes.treeGroup : QueryaIconSizes.treeLeaf;
final iconColor = isBrowsable ? primary.withValues(alpha: 0.5) : muted;
Expand Down
3 changes: 0 additions & 3 deletions lib/core/ui/querya_icon_sizes.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ abstract final class QueryaIconSizes {
/// Inline tree error indicator.
static const double treeError = 14;

/// SDUI explorer tree nodes.
static const double sduiNode = 16;

/// Menu / dialog leading icons.
static const double menuLeading = 18;
}
6 changes: 6 additions & 0 deletions test/core/ui/querya_icons_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,10 @@ void main() {
QueryaIconSizes.sidebarConnectionIcon,
);
});

test('SDUI trees share native treeGroup/treeLeaf sizes (no sduiNode)', () {
// Guards against reintroducing a dead parallel size token (#497).
expect(QueryaIconSizes.treeGroup, 13);
expect(QueryaIconSizes.treeLeaf, 12);
});
}
Loading