Skip to content

fix: code-review follow-ups (#464–#468) - #469

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/464-468-code-review-fixes
Jul 27, 2026
Merged

fix: code-review follow-ups (#464–#468)#469
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/464-468-code-review-fixes

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

Test plan

  • flutter test test/core/database/sql_limit_test.dart
  • flutter test test/core/theme/theme_folder_watcher_test.dart
  • flutter test test/shared/data_export_service_test.dart
  • Manual: export large table, force failure → no partial file left
  • Manual: PG schema expand with broken connection → error, no stale children
  • Manual: edit theme JSON rapidly while refresh slow → later edits applied
  • Manual: Redis SCAN with TYPE/TTL failure then success → banner clears

Skip LIMIT rewriting inside SQL string/dollar quotes, delete partial
exports on failure, clear stale PG tree on error, queue theme watcher
refreshes while in flight, and clear Redis TYPE/TTL error on success.

Closes #464
Closes #465
Closes #466
Closes #467
Closes #468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working core Core library logic and services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant