Skip to content

fix(ui): always pop DDL loading overlay (#447) #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 27, 2026
Merged

fix(ui): always pop DDL loading overlay (#447) #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/features/extensions/extension_table_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
}

Future<void> _openDdlDialog() async {
final navigator = material.Navigator.of(context, rootNavigator: true);
unawaited(showAppDialog<void>(
context: context,
barrierDismissible: false,
Expand All @@ -191,8 +192,8 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
nodeId: widget.tableName,
nodeType: widget.isView ? 'view' : 'table',
);
if (navigator.canPop()) navigator.pop();
if (!mounted) return;
material.Navigator.of(context).pop();

final ddlText = meta.ddl?.trim().isNotEmpty == true
? meta.ddl!
Expand Down Expand Up @@ -223,8 +224,8 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
),
);
} catch (e) {
if (navigator.canPop()) navigator.pop();
if (!mounted) return;
material.Navigator.of(context).pop();
showAppToast(
context: context,
message: 'Failed to fetch DDL: $e',
Expand Down
5 changes: 3 additions & 2 deletions lib/features/sqlite/sqlite_table_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ class _SqliteTableViewState extends material.State<SqliteTableView> {
Future<void> _showDdlDialog() async {
final conn = _connection;
if (conn == null || !conn.isConnected) return;
final navigator = material.Navigator.of(context, rootNavigator: true);
unawaited(showAppDialog<void>(
context: context,
barrierDismissible: false,
Expand All @@ -203,8 +204,8 @@ class _SqliteTableViewState extends material.State<SqliteTableView> {
));
try {
final ddl = await conn.getObjectDdl(widget.tableName);
if (navigator.canPop()) navigator.pop();
if (!mounted) return;
material.Navigator.of(context).pop();
await showAppDialog<void>(
context: context,
builder: (ctx) => material.AlertDialog(
Expand All @@ -230,8 +231,8 @@ class _SqliteTableViewState extends material.State<SqliteTableView> {
),
);
} catch (e) {
if (navigator.canPop()) navigator.pop();
if (!mounted) return;
material.Navigator.of(context).pop();
showAppToast(
context: context,
message: 'Failed to fetch DDL: $e',
Expand Down
Loading