Skip to content

perf(ui): static BackdropFilter blur for dialogs (#359) #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 26, 2026
Merged

perf(ui): static BackdropFilter blur for dialogs (#359) #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions lib/shared/widgets/app_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,23 +101,25 @@ class _BlurredDialogScaffoldState extends State<_BlurredDialogScaffold> {
child: Stack(
fit: StackFit.expand,
children: [
// Backdrop: animates blur sigma and dim alpha directly (no FadeTransition).
// Backdrop: static blur; only opacity/dim animate (blur sigma is expensive).
Positioned.fill(
child: GestureDetector(
behavior: HitTestBehavior.opaque,
onTap: widget.barrierDismissible ? widget.onDismiss : null,
child: AnimatedBuilder(
animation: curved,
builder: (ctx, _) {
final t = curved.value;
return ClipRect(
child: BackdropFilter(
filter:
ImageFilter.blur(sigmaX: 8.0 * t, sigmaY: 8.0 * t),
child: Container(
color: Colors.black.withValues(alpha: 0.32 * t),
),
child: ClipRect(
child: BackdropFilter(
filter: ImageFilter.blur(sigmaX: 8, sigmaY: 8),
child: const ColoredBox(
color: Color(0x52000000), // black @ 0.32
),
),
),
builder: (ctx, child) {
return Opacity(
opacity: curved.value.clamp(0.0, 1.0),
child: child,
);
},
),
Expand Down
19 changes: 19 additions & 0 deletions test/shared/app_dialog_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:ui' show ImageFilter;

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:querya_desktop/core/motion/querya_motion.dart';
Expand Down Expand Up @@ -83,6 +85,23 @@ void main() {
expect(find.byType(ScaleTransition), findsNothing);
});

testWidgets('backdrop keeps static blur sigma; opacity carries enter',
(tester) async {
final ctx = await pumpHost(tester);

showAppDialog<void>(
context: ctx,
builder: (c) => const SimpleDialog(title: Text('Blur')),
);
// Mid-enter: blur must stay sigma 8 (not sigma * t).
await tester.pump();
await tester.pump(const Duration(milliseconds: 40));

final filter = tester.widget<BackdropFilter>(find.byType(BackdropFilter));
expect(filter.filter, ImageFilter.blur(sigmaX: 8, sigmaY: 8));
expect(find.byType(Opacity), findsWidgets);
});

testWidgets('enter uses standard duration under full motion', (tester) async {
final ctx = await pumpHost(tester);
showAppDialog<void>(
Expand Down
Loading