Skip to content

feat(ui): morph ResultsTab idle/loading/error/grid (#342) - #350

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/342-results-state-morph
Jul 26, 2026
Merged

feat(ui): morph ResultsTab idle/loading/error/grid (#342)#350
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/342-results-state-morph

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • ResultsTab morphs idle → loading → error/status/affected → grid via QueryaFadeSlide.
  • Mode keys are stable per mode (not per row/data), so grid refreshes and scroll virtualization do not re-trigger fades.
  • Prefer FadeSlide over SwitchingBody so large grids are not keep-alive mounted under spinner/error.
  • Expanded widget tests for modes, morph, motion-off snap, and row-update stability.

Phase B slice of #342 (results states). Remaining: dialog enter/exit, theme motion, split settle.

Linked issue

Refs #342

Checklist

  • flutter analyze and flutter test pass locally
  • Scope matches the linked issue only (no drive-by refactors)
  • PR targets dev (not main, unless hotfix)

Test plan

  • flutter test test/features/main_screen/results_tab_test.dart
  • Manual: run SQL — idle → spinner → grid; force error — spinner → error text
  • Manual: motion Off — mode swaps snap
  • Manual: scroll a large result set — no per-row fade

Made with Cursor

Wrap query output modes in QueryaFadeSlide with stable per-mode keys so
shell transitions feel continuous without animating virtualized rows.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added epic Epic / umbrella issue accessibility Reduced motion, OS accessibility preferences ui User interface components and widgets labels Jul 26, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 69da4bb into dev Jul 26, 2026
4 checks passed
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
feat(ui): morph ResultsTab idle/loading/error/grid (#342)
@ZhuchkaTriplesix ZhuchkaTriplesix self-assigned this Jul 27, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/342-results-state-morph branch July 27, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Reduced motion, OS accessibility preferences epic Epic / umbrella issue ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant