fix(ui): global File menu SQL intents outside SQL workspace - #297
Merged
Conversation
Ensures New/Open/Save work from the title bar and non-SQL views by opening the SQL workspace or showing a hint when no SQL connection is active. Fixes #268
Fixes prefer_const_constructors analyzer warnings in CI.
3 tasks
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
fix(ui): global File menu SQL intents outside SQL workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqlEditorGlobalActionsfallback atMainScreenso File → New/Open/Save works from the title bar and non-SQL views (table view, MongoDB, Redis, empty workspace).SqlEditorCommandBridgeso mounted SQL workspaces handle commands when menu focus is outside the editor subtree.Fixes #268
Test plan
flutter test test/core/actions/