feat(connections): add SSL certificate file pickers to PostgreSQL form - #264
Merged
Merged
Conversation
#260) Add optional file pickers for sslrootcert, sslcert, and sslkey. Paths are stored in the connection URI (which is already persisted in the secure store), and the URI is auto-generated when certificate paths are provided in host/port mode. The certificate fields are also pre-populated from an existing URI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260
Summary
Add optional file pickers for PostgreSQL TLS client certificates and custom CA roots, removing the need for users to hand-craft URIs with
sslrootcert=,sslcert=, andsslkey=parameters.Changes
Use SSL/TLSis enabled.Test plan
flutter analyzeflutter test test/features/postgresql/postgresql_connection_form_test.dartflutter test test/core/database/postgres_connection_test.dartflutter test test/core/database/postgres_connection_pool_test.dart