fix(connections): validate PostgreSQL sslmode and map useSSL correctly - #261
Merged
Merged
Conversation
#249, #253, #254, #257, #258) - Reject unsupported sslmode values (e.g. prefer, invalid) for PostgreSQL. - Map disable → useSSL=false; require, verify-ca, verify-full → useSSL=true. - Only store an explicit URI port; fall back to driver defaults when omitted. - Keep host:port in display name when no database is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249
Closes #253
Closes #254
Closes #257
Closes #258
Summary
Tighten PostgreSQL connection URL parsing so invalid
sslmodevalues are rejected at input time, supported values are mapped to the correctuseSSLflag, and omitted ports fall back to driver defaults.Changes
sslmodevalues for PostgreSQL (prefer,invalid, etc.) inparseConnectionUrlInput.disable→useSSL=false;require,verify-ca,verify-full→useSSL=true.host:portin the display name when no database is present.Test plan
flutter test test/features/connections/connection_url_parser_test.dart(20 tests, all passing).