security(mysql): replace string concatenation with parameterized queries in schema introspection (#241) - #247
Merged
Conversation
…ies in schema introspection (#241)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #241 by replacing string concatenation and manual escaping (
_escapeSqlString) with parameterized queries (paramsin theexecutemethod) for schema introspection methods (listViews,listColumnNames,listTables) in the MySQL database connection driver.Changes
listViews,listColumnNames, andlistTablesinlib/core/database/mysql_connection.dartto use colon-based named parameters (e.g.:schema,:database,:table)._escapeSqlStringmethod since it is no longer used.test/core/database/mysql_connection_test.dartto verifyMysqlConnectionbehavior in non-connected states.CHANGELOG.mdaccordingly.