Fix: SQL editor executes entire file instead of selection - #213
Merged
Conversation
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jun 21, 2026
* Fix #211: Execute only selected SQL text and strip SQLite comments (#213) * feat(extensions): implement LocalExtensionRegistry (EXT-2) (#214) - Add ExtensionPaths for locating ~/.querya/extensions - Add LocalExtensionRegistry for parsing manifest.json from extensions dir - Add installPath to ExtensionManifest * Test: Unit Tests for Extension Registry (EXT-4) (#215) * test(extensions): add unit tests for LocalExtensionRegistry (EXT-4) - Mock ExtensionPaths.extensionsDirectory for testing - Verify registry parses valid manifests - Verify invalid manifests and plain files are ignored - Verify registry cache logic * fix(extensions): use flutter foundation for @VisibleForTesting instead of meta to satisfy linter * Feat: Migrate Custom Themes to Extension Registry (EXT-3) (#216) * fix(theme): use braces for multiline if statement * fix(theme): fix theme registry migration unit tests and watcher path * fix(theme): remove unused import theme_paths.dart * test(settings): fix preferences appearance section widget test by mocking extensions dir and utilizing pumpAndSettle * Fix TOCTOU, ID collisions, redundant scans, and remove legacy theme code (#221) * chore(release): prepare release 0.4.7
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jun 22, 2026
* Fix #211: Execute only selected SQL text and strip SQLite comments (#213) * feat(extensions): implement LocalExtensionRegistry (EXT-2) (#214) - Add ExtensionPaths for locating ~/.querya/extensions - Add LocalExtensionRegistry for parsing manifest.json from extensions dir - Add installPath to ExtensionManifest * Test: Unit Tests for Extension Registry (EXT-4) (#215) * test(extensions): add unit tests for LocalExtensionRegistry (EXT-4) - Mock ExtensionPaths.extensionsDirectory for testing - Verify registry parses valid manifests - Verify invalid manifests and plain files are ignored - Verify registry cache logic * fix(extensions): use flutter foundation for @VisibleForTesting instead of meta to satisfy linter * Feat: Migrate Custom Themes to Extension Registry (EXT-3) (#216) * fix(theme): use braces for multiline if statement * fix(theme): fix theme registry migration unit tests and watcher path * fix(theme): remove unused import theme_paths.dart * test(settings): fix preferences appearance section widget test by mocking extensions dir and utilizing pumpAndSettle * Fix TOCTOU, ID collisions, redundant scans, and remove legacy theme code (#221) * chore(release): prepare release 0.4.7 * feat(menu): implement File -> Exit to close the application window (#230) * feat(menu): implement File -> New, Open..., Save actions (#231) * feat(menu): implement File -> New, Open..., Save actions via Intents/Actions * refactor(menu): remove unnecessary widgets import in title bar * feat: implement connection management improvements and read-only mode (Issues #225, #226) (#232) * feat(connection): implement connection actions and fix layout test hang * feat(connection): implement Invalidate/Reconnect menu item * feat: implement Connection -> Read-only mode for database connections * fix ci * docs: document SQLite support, read-only mode, and connection actions * chore(release): prepare pre-release 0.4.7-a
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
* Fix #211: Execute only selected SQL text and strip SQLite comments (#213) * feat(extensions): implement LocalExtensionRegistry (EXT-2) (#214) - Add ExtensionPaths for locating ~/.querya/extensions - Add LocalExtensionRegistry for parsing manifest.json from extensions dir - Add installPath to ExtensionManifest * Test: Unit Tests for Extension Registry (EXT-4) (#215) * test(extensions): add unit tests for LocalExtensionRegistry (EXT-4) - Mock ExtensionPaths.extensionsDirectory for testing - Verify registry parses valid manifests - Verify invalid manifests and plain files are ignored - Verify registry cache logic * fix(extensions): use flutter foundation for @VisibleForTesting instead of meta to satisfy linter * Feat: Migrate Custom Themes to Extension Registry (EXT-3) (#216) * fix(theme): use braces for multiline if statement * fix(theme): fix theme registry migration unit tests and watcher path * fix(theme): remove unused import theme_paths.dart * test(settings): fix preferences appearance section widget test by mocking extensions dir and utilizing pumpAndSettle * Fix TOCTOU, ID collisions, redundant scans, and remove legacy theme code (#221) * chore(release): prepare release 0.4.7
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
* Fix #211: Execute only selected SQL text and strip SQLite comments (#213) * feat(extensions): implement LocalExtensionRegistry (EXT-2) (#214) - Add ExtensionPaths for locating ~/.querya/extensions - Add LocalExtensionRegistry for parsing manifest.json from extensions dir - Add installPath to ExtensionManifest * Test: Unit Tests for Extension Registry (EXT-4) (#215) * test(extensions): add unit tests for LocalExtensionRegistry (EXT-4) - Mock ExtensionPaths.extensionsDirectory for testing - Verify registry parses valid manifests - Verify invalid manifests and plain files are ignored - Verify registry cache logic * fix(extensions): use flutter foundation for @VisibleForTesting instead of meta to satisfy linter * Feat: Migrate Custom Themes to Extension Registry (EXT-3) (#216) * fix(theme): use braces for multiline if statement * fix(theme): fix theme registry migration unit tests and watcher path * fix(theme): remove unused import theme_paths.dart * test(settings): fix preferences appearance section widget test by mocking extensions dir and utilizing pumpAndSettle * Fix TOCTOU, ID collisions, redundant scans, and remove legacy theme code (#221) * chore(release): prepare release 0.4.7 * feat(menu): implement File -> Exit to close the application window (#230) * feat(menu): implement File -> New, Open..., Save actions (#231) * feat(menu): implement File -> New, Open..., Save actions via Intents/Actions * refactor(menu): remove unnecessary widgets import in title bar * feat: implement connection management improvements and read-only mode (Issues #225, #226) (#232) * feat(connection): implement connection actions and fix layout test hang * feat(connection): implement Invalidate/Reconnect menu item * feat: implement Connection -> Read-only mode for database connections * fix ci * docs: document SQLite support, read-only mode, and connection actions * chore(release): prepare pre-release 0.4.7-a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211.
Changes:
postgres_sql_workspace.dart,mysql_sql_workspace.dart, andsqlite_sql_workspace.dartto execute only the highlighted text if there is an active selection.sqlite_connection.dartto use regular expressions to strip out SQL comments (--and/* ... */) before checking if a query starts withSELECTorPRAGMA, fixing a bug that returned empty sets for valid queries with leading comments.