Skip to content

perf(redis): query key types and TTLs concurrently during scan #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jun 16, 2026
Merged

perf(redis): query key types and TTLs concurrently during scan #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/features/redis/redis_keys_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,17 @@ class _RedisKeysViewState extends material.State<RedisKeysView> {
count: 100,
);

// Fetch type and TTL for each key
final infos = <_KeyInfo>[];
for (final name in keyNames) {
// Fetch type and TTL for each key concurrently
final futures = keyNames.map((name) async {
try {
final type = await widget.connection.keyType(name);
final ttl = await widget.connection.ttl(name);
infos.add(_KeyInfo(name: name, type: type, ttl: ttl));
return _KeyInfo(name: name, type: type, ttl: ttl);
} catch (_) {
infos.add(_KeyInfo(name: name, type: 'unknown', ttl: -1));
return _KeyInfo(name: name, type: 'unknown', ttl: -1);
}
}
});
final infos = await Future.wait(futures);

if (!mounted) return;
setState(() {
Expand Down
Loading