Skip to content

TP-27: Startup fallback for missing/broken selected theme - #153

Merged
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/122-startup-theme-fallback
Jun 14, 2026
Merged

TP-27: Startup fallback for missing/broken selected theme#153
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/122-startup-theme-fallback

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add selectedThemeStartupFallbackMessage and _markRegistrySelectionFailed() so ThemeController.load() falls back to Querya Dark when the persisted registry theme is missing or fails to parse.
  • Keep saved theme id/path in settings; surface a stable Preferences message: "Selected theme failed to load. Using Querya Dark."
  • Align refresh sync to mark registry selection failed when the selected theme disappears from the scanned list.

Test plan

  • flutter test test/core/theme/theme_controller_test.dart (startup fallback cases)
  • flutter analyze
  • Manual: set a broken/missing theme id in settings, restart app → Querya Dark + error in Preferences; pick a valid theme → error clears

Closes #122

Restore persisted registry themes safely on load with Querya Dark as the
active fallback, a stable Preferences error message, and settings kept intact.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes error-handling Theme parser epic label: error-handling stability Theme parser epic label: stability labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026
Do not clear the active registry theme on loadAvailableThemes when the
scanned list no longer includes the selection but the theme is already loaded.

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 7c2b5ef into dev Jun 14, 2026
4 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/122-startup-theme-fallback branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
TP-27: Startup fallback for missing/broken selected theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

error-handling Theme parser epic label: error-handling stability Theme parser epic label: stability theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant