Skip to content

feat(theme): import themes into user themes directory (TP-23) - #149

Merged
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/118-import-themes-registry
Jun 14, 2026
Merged

feat(theme): import themes into user themes directory (TP-23)#149
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/118-import-themes-registry

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add ThemeRegistryService.importThemeFile() with Querya custom / VS Code detection, safe filenames, hash-based reuse, and suffixed ids on conflicts
  • Add ThemeController.importRegistryThemeFile() to refresh the picker and activate the imported theme
  • Switch Preferences Import theme… to the registry flow; legacy imported.json import path remains for existing users

Test plan

  • flutter test test/core/theme/theme_registry_service_test.dart --name importThemeFile
  • flutter test test/core/theme/theme_import_service_test.dart
  • flutter test test/core/theme/theme_controller_test.dart --name importRegistryThemeFile
  • Custom theme import copies to themes/{id}.json and appears in picker
  • VS Code import uses slugified filename
  • Duplicate same-hash import reuses existing file
  • Duplicate same-id different content creates suffixed custom id

Closes #118

Add registry-backed importThemeFile with deduplication by content hash,
slugified VS Code filenames, and suffixed custom theme ids on conflicts.
Wire Preferences Import theme to importRegistryThemeFile while keeping
legacy imported.json flow intact.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes filesystem Theme parser epic label: filesystem settings Theme parser epic label: settings labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 7f29de1 into dev Jun 14, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/118-import-themes-registry branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
feat(theme): import themes into user themes directory (TP-23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filesystem Theme parser epic label: filesystem settings Theme parser epic label: settings theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant