Skip to content

feat(settings): Refresh themes action in Preferences (TP-22) - #148

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/117-refresh-themes
Jun 14, 2026
Merged

feat(settings): Refresh themes action in Preferences (TP-22)#148
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/117-refresh-themes

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add Refresh themes button next to Import/Reset in Appearance preferences
  • Extend ThemeController.loadAvailableThemes() with isLoadingAvailableThemes, safe rescan, and active-theme preservation (no disk reload on refresh)
  • Show non-blocking loading state on ThemePickerButton while refresh runs

Test plan

  • flutter test test/core/theme/theme_controller_test.dart --name loadAvailableThemes
  • flutter test test/features/settings/preferences_appearance_section_test.dart
  • New filesystem theme appears after refresh
  • Active registry theme stays applied when scan skips a broken file
  • isLoadingAvailableThemes toggles during refresh
  • Refresh themes button visible in Preferences

Closes #117

Expose isLoadingAvailableThemes on ThemeController, rescan registry
definitions without reloading the active theme, and wire a non-blocking
Refresh themes button plus picker loading state in Appearance.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes filesystem Theme parser epic label: filesystem settings Theme parser epic label: settings labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 10ecf93 into dev Jun 14, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/117-refresh-themes branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
feat(settings): Refresh themes action in Preferences (TP-22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filesystem Theme parser epic label: filesystem settings Theme parser epic label: settings theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant