Skip to content

feat(settings): ThemePreviewCard with debounced hover preview (TP-20) - #146

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/115-theme-preview-card
Jun 14, 2026
Merged

feat(settings): ThemePreviewCard with debounced hover preview (TP-20)#146
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/115-theme-preview-card

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add ThemePreviewCard showing background, surface, primary/accent swatches, sample text, and editor strip
  • Extend ThemePickerButton with optional onPreviewTheme callback, 120ms debounced hover preview, and local preview state (never calls onSelected on hover)
  • Broken previews show a non-blocking error message inside the card

Test plan

  • flutter test test/features/settings/theme_preview_card_test.dart test/features/settings/theme_picker_button_test.dart
  • Hover does not trigger onSelected
  • Preview resolves after debounce and updates card
  • Broken preview shows error in card
  • Preview card hidden when onPreviewTheme is not provided

Closes #115

Introduce a compact preview card and optional onPreviewTheme callback
on ThemePickerButton so hovering a row loads preview data locally
without applying the theme app-wide.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes performance Theme parser epic label: performance settings Theme parser epic label: settings labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 93f745d into dev Jun 14, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/115-theme-preview-card branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
feat(settings): ThemePreviewCard with debounced hover preview (TP-20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Theme parser epic label: performance settings Theme parser epic label: settings theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant