Skip to content

feat(theme): ThemeController registry integration (#112) - #143

Merged
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/112-theme-controller-registry
Jun 14, 2026
Merged

feat(theme): ThemeController registry integration (#112)#143
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/112-theme-controller-registry

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • ThemeController loads registry definitions on load() and restores persisted theme_selected_* settings.
  • Add availableThemes, selectedThemeId, selectedThemeLoadError, loadAvailableThemes, setThemeById, and previewThemeById.
  • Broken selected themes fall back to Querya Dark at runtime without clearing stored settings; setPreset clears registry selection.

Test plan

  • flutter test test/core/theme/theme_controller_test.dart
  • flutter test test/core/theme/

Closes #112

Load registry definitions on startup, restore selected theme by id, and add
setThemeById/previewThemeById while preserving legacy preset behavior.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes controller Theme parser epic label: controller labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

visibleForTesting is already available through shadcn_flutter.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit d5820ad into dev Jun 14, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/112-theme-controller-registry branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
…istry

feat(theme): ThemeController registry integration (#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controller Theme parser epic label: controller theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant