Skip to content

feat(theme): legacy imported theme registry migration (#111) - #142

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/111-legacy-imported-migration
Jun 14, 2026
Merged

feat(theme): legacy imported theme registry migration (#111)#142
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/111-legacy-imported-migration

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add ThemeSource.legacyImported definition during loadThemeDefinitions from persisted import settings/file.
  • Expose ThemeImportService.legacyImportedThemeId and persistedImportFile().
  • Skip themes/imported.json in filesystem scan to avoid duplicate entries; old settings are preserved.

Test plan

  • flutter test test/core/theme/theme_registry_legacy_import_test.dart
  • flutter test test/core/theme/theme_registry_service_test.dart
  • flutter test test/core/theme/theme_controller_test.dart

Closes #111

Expose persisted import metadata as ThemeSource.legacyImported and skip
duplicate filesystem scan of themes/imported.json.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes compatibility Theme parser epic label: compatibility migration Theme parser epic label: migration labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 7deaa34 into dev Jun 14, 2026
4 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/111-legacy-imported-migration branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
…ation

feat(theme): legacy imported theme registry migration (#111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Theme parser epic label: compatibility migration Theme parser epic label: migration theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant