feat(theme): load theme by ThemeDefinition (#108) - #139
Merged
Conversation
Wire custom and VS Code parsers through ThemeRegistryService.loadTheme with controlled failures for missing, unreadable, or invalid theme files.
github-actions
Bot
added
theme
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
feat(theme): load theme by ThemeDefinition (#108)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThemeRegistryService.loadThemereturningThemeLoadSuccess/ThemeLoadFailure.QueryaThemeManifest+queryaThemeFromManifest.VsCodeThemeManifest+buildQueryaThemeFromVsCodeManifest.Test plan
flutter test test/core/theme/theme_registry_service_test.dartCloses #108