Conversation
Member
Author
|
I also wonder why we need both |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
|
The reason is that some truncation strategies can be made more efficient when working with data that it knows is already sorted, but our current implementation in TensorKit has to deal with multiple blocks so that is only implicitly visible in the per block implementation. |
lkdvos
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
which affects
eig(h)_truncwithtruncspace(see QuantumKitHub/PEPSKit.jl#314). Still need to come up with tests to catch this case, though.