Draft
Conversation
Member
|
The current implementation will also completely break GPU support, no? Other than that, it looks very clean 😄 . |
Member
Author
|
Yes, so I think we should just put this on the shelf for now, I was hoping it would cause less issues 😬 |
kshyatt
force-pushed
the
stridedblock
branch
from
c136a58 to
6be8f44
Compare
Member
GPU support should now be unbroken! Let's try this again |
Member
Author
|
Reminder that the main blocker for this is the lack of support for matrix functions for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will leave this here as a WIP for now, since some of the matrix functions still require
<:Base.StridedMatrix(e.g.exp!, ...) to work.This will probably be solved once we have more support in MatrixAlgebraKit, but since this is not urgent I'll just leave this as-is for now.