Conversation
lkdvos
reviewed
Jan 5, 2026
lkdvos
reviewed
Jan 5, 2026
lkdvos
reviewed
Jan 5, 2026
lkdvos
reviewed
Jan 5, 2026
Member
There was a problem hiding this comment.
I would slightly prefer to have these changes as specializations in the GPU extensions, but definitely happy to try them out like this
Member
Author
|
OK, got the column permutation for |
Jutho
reviewed
Jan 6, 2026
Jutho
reviewed
Jan 6, 2026
Jutho
reviewed
Jan 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Jutho
reviewed
Jan 6, 2026
Member
Author
|
We can probably use the struct Truncerr_BinaryAdder{T}
p::T
end
(a::Truncerr_BinaryAdder)(x, y) = x + abs(y)^a.pThen in the GPU extensions do: But that can happen in a separate PR since this is holding up TK. |
Jutho
approved these changes
Jan 6, 2026
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
lkdvos
referenced
this pull request
Jan 8, 2026
* Bump version * update changelog --------- Co-authored-by: Lukas Devos <ldevos98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to address #138