Open
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
reviewed
Feb 16, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Would it be possible to refactor the test suite so we can actually reuse it? It's really not the goal to have to copy that code, the point of the suite was to be able to reuse it
lkdvos
reviewed
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TKS 0.3.6 improved on the test suite.
Sadly we can't just blindly import that because of the use of sparse arrays here, so multiple tests are actually not brought over.I'm also not sure of how much is being doubly tested. I wrote the tests assuming every fusion category is not in the braided list and vice versa.
Edit: This requires a new version release of TKS (QuantumKitHub/TensorKitSectors.jl#70)