Skip to content

Satisfy trait type condition#18

Open
filchristou wants to merge 1 commit intoQuantumBFS:masterfrom
filchristou:traittype
Open

Satisfy trait type condition#18
filchristou wants to merge 1 commit intoQuantumBFS:masterfrom
filchristou:traittype

Conversation

@filchristou
Copy link
Copy Markdown
Contributor

is_directed(::Type{CustomGraph})::Bool should be defined to be consistent with Graphs.jl
https://juliagraphs.org/Graphs.jl/dev/ecosystem/interface/

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.95%. Comparing base (f7553c7) to head (2537441).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   92.46%   91.95%   -0.51%     
==========================================
  Files           5        6       +1     
  Lines         345      348       +3     
==========================================
+ Hits          319      320       +1     
- Misses         26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a bug, I just caught it with https://github.com/gdalle/GraphsInterfaceChecker.jl

Copy link
Copy Markdown

@oameye oameye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also hitting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants