NXC-357: Add broker buy and sell response models to support notifications - #18
Merged
Merged
Conversation
PJvGrol
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the callback response models in
CallbacksModel.csto support broker buy and sell transactions, and enhances the data included in several transaction response classes. These changes improve the SDK's ability to represent and handle a wider variety of crypto transaction notifications with more detailed information.Support for broker transactions:
LabelNotificationTxBrokerBuyResponseandLabelNotificationTxBrokerSellResponseto represent broker buy and sell transaction notifications, including fields for transaction ID, crypto/fiat amounts, addresses, and blockchain messages.LabelNotificationResponseto includeBrokerBuyandBrokerSellproperties for handling these new transaction types.Enhancements to existing transaction responses:
CryptoAmountandDestinationAddressfields toLabelNotificationTxSendoutResponsefor more detailed sendout transaction data.LabelNotificationTxReceiveInResponsewith new fields:ReceivedFiatValue,ReceiveAddress, andBlockchainMessagefor richer receive-in transaction information.