NXC-289: Change UpdateCustomerRequest Currency property - #15
Merged
Merged
Conversation
AsimaksiAnt
commented
Jun 16, 2026
AsimaksiAnt
commented
Contributor
- Change currencyId to currencyCode
- Add 'Other' type in CustomerPersonType enum
- Change currencyId to currencyCode - Add 'Other' type in CustomerPersonType enum
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SDK’s customer models to align with an API change: UpdateCustomerRequest now uses a currency code instead of an integer currency id, and customer-person relationships gain an additional Other classification.
Changes:
- Replaced
UpdateCustomerRequest.CurrencyId(int?) withCurrencyCode(string?). - Added
Otherto theCustomerPersonTypeenum.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Nexus.Crypto.SDK/Models/Customer/CustomerModel.cs | Renames the update-request currency field from ID-based to code-based. |
| src/Nexus.Crypto.SDK/Models/CustomerPerson.cs | Extends CustomerPersonType with Other to support an additional person linkage type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raymens
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.