NXC-244: Forward custom header to nested services - #12
Closed
AsimaksiAnt wants to merge 1 commit into
Closed
AsimaksiAnt wants to merge 1 commit into
AsimaksiAnt wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK service composition so that custom headers configured on NexusAPIService are also applied to requests made through nested service properties (DocumentStore* and Customer), aligning nested-service behavior with top-level API calls.
Changes:
- Added a shared, optional
headersdictionary toBaseServiceand forwarded it through selected service constructors. - Updated
NexusAPIServiceto instantiate nested services using the same_headersdictionary soAddHeaderaffects them too.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nexus.Crypto.SDK/Services/BaseService.cs | Accepts an optional headers dictionary and uses it as the backing store for _headers. |
| src/Nexus.Crypto.SDK/NexusAPIService.cs | Constructs nested services with the shared _headers so custom headers propagate. |
| src/Nexus.Crypto.SDK/Services/DocumentStoreSettingsService.cs | Adds optional headers parameter and forwards it to BaseService. |
| src/Nexus.Crypto.SDK/Services/DocumentStoreTypeService.cs | Adds optional headers parameter and forwards it to BaseService. |
| src/Nexus.Crypto.SDK/Services/DocumentStoreRecordService.cs | Adds optional headers parameter and forwards it to BaseService. |
| src/Nexus.Crypto.SDK/Services/CustomerService.cs | Adds optional headers parameter and forwards it to BaseService. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.