Skip to content

Fix full-screen blue tint when staring at a secret's highlight box #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kovalancik06-max wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Fix full-screen blue tint when staring at a secret's highlight box #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/io/github/quantizr/dungeonrooms/dungeons/catacombs/Waypoints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,15 @@ public void onWorldRender(RenderWorldLastEvent event) {
double distSq = x*x + y*y + z*z;

GlStateManager.disableDepth();
GlStateManager.disableCull();
// Keep face culling enabled for the filled box: with it disabled, staring at (or
// standing inside) a secret's box renders every inward-facing wall with no depth
// test to hide them, tinting the whole screen with the secret's color (#24).
// Culling is still disabled below for the beacon beam, which needs to be visible
// from both sides.
if (showBoundingBox && frustum.isBoxInFrustum(pos.getX(), pos.getY(), pos.getZ(), pos.getX() + 1, pos.getY() + 1, pos.getZ() + 1)) {
WaypointUtils.drawFilledBoundingBox(new AxisAlignedBB(x, y, z, x + 1, y + 1, z + 1), color, 0.4f);
}
GlStateManager.disableCull();
GlStateManager.disableTexture2D();
if (showBeacon && distSq > 5*5) WaypointUtils.renderBeaconBeam(x, y + 1, z, color.getRGB(), 0.25f, event.partialTicks);
if (showWaypointText) WaypointUtils.renderWaypointText(secretsObject.get("secretName").getAsString(), pos.up(2), event.partialTicks);
Expand Down